Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 1ES pools for live tests. #17973

Merged
merged 6 commits into from
Jan 21, 2021
Merged

Enable 1ES pools for live tests. #17973

merged 6 commits into from
Jan 21, 2021

Conversation

mitchdenny
Copy link
Contributor

@mitchdenny mitchdenny commented Jan 14, 2021 •
edited
Loading

This PR adds support for 1ES pools on live test pipelines. It does this by adding a Pool parameter to platform entries which is then propagated down into the test job template as a variable in the matrix (which is then used in the pool: setting on jobs.

@mitchdenny mitchdenny self-assigned this Jan 14, 2021
@mitchdenny mitchdenny added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Jan 14, 2021
@mitchdenny
Copy link
Contributor Author

/azp run net - appconfiguration - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run net - appconfiguration - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run net - appconfiguration - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run net - appconfiguration - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run net - identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

@benbp this largely works but the issue that I'm running into is that the identity test pipeline uses a container image which doesn't have .NET 5.0 on it. The host agents do now have .NET 5.0 and our install steps have been commented out. I think the right course of action here is to rev the container image that we are using.

@benbp
Copy link
Member

benbp commented Jan 14, 2021

@mitchdenny the container issue to update to net50 is being worked on by @schaabs

@benbp
Copy link
Member

benbp commented Jan 14, 2021

#17980 @mitchdenny

@mitchdenny
Copy link
Contributor Author

/azp run net - identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run net - identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run net - appconfiguration - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny force-pushed the enable-1es-pools-for-live-testing branch from 13c27f9 to 6291f76 Compare January 21, 2021 00:46
@mitchdenny
Copy link
Contributor Author

/azp run net - identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run net - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp net - appconfiguration - tests

@azure-pipelines
Copy link

Command 'net' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@mitchdenny
Copy link
Contributor Author

/azp run net - appconfiguration - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny merged commit 3683d32 into Azure:master Jan 21, 2021
@mitchdenny mitchdenny deleted the enable-1es-pools-for-live-testing branch January 21, 2021 02:42
minnieliu pushed a commit to minnieliu/azure-sdk-for-net that referenced this pull request Jan 23, 2021
@mitchdenny
Enable 1ES pools for live tests. (Azure#17973)
caae541 
* Enable 1ES pools for live tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees

@mitchdenny mitchdenny

Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchdenny @benbp @weshaggard